Skip to content

bench: refactor to use dynamic memory allocation in blas/base/ddot#8713

Merged
kgryte merged 9 commits intostdlib-js:developfrom
farazghani:issue-ddot
Dec 3, 2025
Merged

bench: refactor to use dynamic memory allocation in blas/base/ddot#8713
kgryte merged 9 commits intostdlib-js:developfrom
farazghani:issue-ddot

Conversation

@farazghani
Copy link
Copy Markdown
Contributor

@farazghani farazghani commented Dec 2, 2025 •
edited by kgryte
Loading

Resolves a part of #8643

Description

What is the purpose of this pull request?

This pull request:

This update follows the RFC guidance for replacing patterns such as:
double x[len];
with:
double *x;
x = (double *) malloc( len * sizeof( double ) );
free( x );

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

Faraz Ghani and others added 4 commits November 16, 2025 02:57
chore: fix JavaScript lint errors (issue stdlib-js#8508)
87bfa26
bench: refactor to use dynamic memory allocation in blas/base/drot
89624b3 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
bench: refactor to use dynamic memory allocation in blas/base/dcopy
c354cf2 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
bench: refactor to use dynamic memory allocation in blas/base/ddot
faac90b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Dec 2, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Dec 2, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/base/ddot $\color{green}408/408$
$color{green}+100.00%$ 		$\color{green}28/28$
$color{green}+100.00%$ 		$\color{green}4/4$
$color{green}+100.00%$ 		$\color{green}408/408$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Dec 2, 2025

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.

Required action:
Use "Progresses" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@Planeshifter Planeshifter self-assigned this Dec 3, 2025
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Dec 3, 2025
Planeshifter and others added 3 commits December 2, 2025 19:58
@Planeshifter
chore: remove empty line
1e62c58 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@kgryte
Discard changes to lib/node_modules/@stdlib/blas/base/drot/benchmark/…
e8a8d95 
…c/benchmark.length.c
@kgryte
Discard changes to lib/node_modules/@stdlib/ndarray/base/assert/is-ro…
693939b 
…w-major/examples/index.js
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Dec 3, 2025
@kgryte kgryte changed the title bench: refactor to use dynamic memory allocation in blas/base/ddot bench: refactor to use dynamic memory allocation in blas/base/ddot Dec 3, 2025
kgryte
kgryte reviewed Dec 3, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 3, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
f8677a7 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up. Please ensure that you have a clean Git history and your PRs are only touching a single package. Please refer to our developer guide for additional tips and tricks regarding branching.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 3, 2025
@kgryte kgryte merged commit 57d4088 into stdlib-js:develop Dec 3, 2025
17 checks passed
nakul-krishnakumar pushed a commit to nakul-krishnakumar/stdlib that referenced this pull request Dec 3, 2025
@farazghani @kgryte
@Planeshifter @nakul-krishnakumar
bench: refactor to use dynamic memory allocation in blas/base/ddot
710639e 
PR-URL: stdlib-js#8713
Ref: stdlib-js#8643
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
@farazghani
Copy link
Copy Markdown
Contributor Author

farazghani commented Dec 3, 2025

Thanks for the feedback! I’ll clean up the Git history and ensure future PRs only touch a single package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter left review comments

@kgryte kgryte kgryte approved these changes

Assignees

@Planeshifter Planeshifter

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@farazghani @stdlib-bot @Planeshifter @kgryte